Fix an issue writer cannot write status type (+)#22
Merged
greedy52 merged 1 commit intorelease/v9.0.0-rc.1from Dec 14, 2022
Merged
Fix an issue writer cannot write status type (+)#22greedy52 merged 1 commit intorelease/v9.0.0-rc.1from
greedy52 merged 1 commit intorelease/v9.0.0-rc.1from
Conversation
greedy52
changed the title
Author
Yes. I am planning to push it upstream. It's only an internal type so it may not make too much difference for them in general but will open a PR there anyway and see if they will take it. |
greedy52
added a commit
that referenced
this pull request
Mar 7, 2023
greedy52
added a commit
that referenced
this pull request
Mar 8, 2023
* Fix an issue status type (+) is not read/write properly (#22) * add an option for using StatusString vs string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue:
gravitational/teleport#18776
Cause:
Driver reads
+<status>as a golangstringso writer will write$<len><status>instead of+<status>Change:
Define a type alias
type StatusString stringand write+<status>if interface isStatusStringI think we should also update upstream. Will create a PR to upstream if we all agree.